helix-mods/helix-term
Michael Davis c6b83368b3
Capture word parts while calculating shellwords (#4632)
This fixes an edge case for completing shellwords. With a file
"a b.txt" in the current directory, the sequence `:open a\<tab>`
will result in the prompt containing `:open aa\ b.txt`. This is
because the length of the input which is trimmed when replacing with
completion is calculated on the part of the input which is parsed by
shellwords and then escaped (in a separate operation), which is lossy.
In this case it loses the trailing backslash.

The fix provided here refactors shellwords to track both the _words_
(shellwords with quotes and escapes resolved) and the _parts_ (chunks
of the input which turned into each word, with separating whitespace
removed). When calculating how much of the input to delete when
replacing with the completion item, we now use the length of the last
part.

This also allows us to eliminate the duplicate work done in the
`ends_with_whitespace` check.
2022-11-17 10:00:48 +09:00
..
src Capture word parts while calculating shellwords (#4632) 2022-11-17 10:00:48 +09:00
tests Fix range offsets for multiple shell insertions (#4619) 2022-11-14 09:45:52 +09:00
.gitignore Initial import. 2020-05-20 18:14:51 +09:00
build.rs Resolve a bunch of upcoming clippy lints 2022-11-04 21:06:28 +09:00
Cargo.toml build(deps): bump once_cell from 1.15.0 to 1.16.0 (#4548) 2022-10-31 19:31:08 -05:00