a8b123fe17
The language server sends a char offset range within the signature help label text to highlight as the current parameter, but helix uses byte offset ranges for rendering highlights. This was brought up in the [review of the original signature help PR][1], but the ranges were being highlighted correctly, and there were no out of bound or indexing panics. Turns out rust-analyzer was [incorrectly sending byte offsets] instead of char offsets and this made it seem like all was well and good with offsets in helix during initial testing. [1]: https://github.com/helix-editor/helix/pull/1755#discussion_r906715371 [2]: https://github.com/rust-lang/rust-analyzer/pull/12272 |
||
|---|---|---|
| .. | ||
| commands | ||
| keymap | ||
| ui | ||
| application.rs | ||
| args.rs | ||
| commands.rs | ||
| compositor.rs | ||
| config.rs | ||
| health.rs | ||
| job.rs | ||
| keymap.rs | ||
| lib.rs | ||
| main.rs | ||