Gokul Soumya
6e2aaed5c2
Reuse menu::Item trait in picker ( #2814 )
...
* Refactor menu::Item to accomodate external state
Will be useful for storing editor state when reused by pickers.
* Add some type aliases for readability
* Reuse menu::Item trait in picker
This opens the way for merging the menu and picker code in the
future, since a picker is essentially a menu + prompt. More
excitingly, this change will also allow aligning items in the
picker, which would be useful (for example) in the command palette
for aligning the descriptions to the left and the keybinds to
the right in two separate columns.
The item formatting of each picker has been kept as is, even though
there is room for improvement now that we can format the data into
columns, since that is better tackled in a separate PR.
* Rename menu::Item::EditorData to Data
* Call and inline filter_text() in sort_text() completion
* Rename diagnostic picker's Item::Data
2022-07-02 13:21:27 +02:00
Blaž Hrastnik
20cf75dfa1
Strip some more params
2022-03-28 11:02:39 +09:00
Blaž Hrastnik
9a6ee88e66
Split off dap event handlers into helix-view to allow reuse
2022-03-28 11:01:59 +09:00
Blaž Hrastnik
5a60989efe
Bump dependencies
2022-03-08 10:33:40 +09:00
Blaž Hrastnik
7b1d682fe5
dap: fix runInTerminal with lldb-vscode
2022-02-18 14:37:59 +09:00
Blaž Hrastnik
4e1b3b12f3
Refactor symbol picker to share code
2022-02-18 13:50:06 +09:00
Cole Helbling
6118486eb2
helix-term: implement buffer completer
...
In order to implement this completer, the completion function needs to
be able to access the compositor's context (to allow it to get the
list of buffers currently open in the context's editor).
2022-02-17 14:02:42 +09:00
Blaž Hrastnik
d11b652139
Allow static strings in set_status/set_error so API is nicer
2022-02-15 16:45:28 +09:00
Blaž Hrastnik
fd0e4b1159
dap: Reduce amount of block_on uses
2022-02-15 16:30:23 +09:00
Blaž Hrastnik
1422449537
..
2022-02-15 11:37:33 +09:00
Blaž Hrastnik
eeb9b39857
Fix build on master
2022-02-15 10:33:55 +09:00
Blaž Hrastnik
bd549d8a20
Merge remote-tracking branch 'origin/master' into debug
2022-02-13 18:31:51 +09:00
Blaž Hrastnik
7ad8eaaef0
wip
2021-12-14 00:41:51 +09:00
Blaž Hrastnik
df3b88387b
dap: Improve variables UI
2021-12-09 11:28:53 +09:00
Blaž Hrastnik
dac317e620
TODO
2021-12-09 10:55:32 +09:00
Blaž Hrastnik
60c86eff89
dap: Simplify a few more statements that could use the debugger macro
2021-12-09 10:55:32 +09:00
Blaž Hrastnik
d8351d35ab
dap: Extract a macro that fetches a debugger or returns
2021-12-08 00:59:11 +09:00
Blaž Hrastnik
e98993d609
dap: Fix an off-by-one error when jumping
2021-12-08 00:22:48 +09:00
Blaž Hrastnik
bf8437d098
clippy lint
2021-12-06 09:36:02 +09:00
Blaž Hrastnik
dc8df7ba21
Make thread_picker non-blocking
2021-12-06 09:35:59 +09:00
Blaž Hrastnik
d5d1a9b1ae
Apply suggestions from code review
...
Co-authored-by: Gokul Soumya <gokulps15@gmail.com>
2021-12-06 09:32:11 +09:00
Blaž Hrastnik
43fbb6d965
Make dap_start non-blocking
2021-12-03 13:27:00 +09:00
Blaž Hrastnik
2dbf966293
dap: Start working on runInTerminal support
2021-12-03 11:59:44 +09:00
Blaž Hrastnik
d14ca05d6b
Simplify some cases that use return None to use ?
2021-12-02 10:31:19 +09:00
Blaž Hrastnik
de5e5863aa
dap: Use cursor_line over cursor + char_to_line
2021-12-02 10:24:17 +09:00
Blaž Hrastnik
54f8e5c9c3
dap: Fix an off-by-one and move the function over to commands/dap
2021-12-02 10:22:17 +09:00
Blaž Hrastnik
573cb39926
dap: Remove some unwraps
2021-12-02 10:20:19 +09:00
Blaž Hrastnik
ffc89e483b
Mark some more TODOs as resolved
2021-12-01 19:28:29 +09:00
Blaž Hrastnik
b4fd3148e3
These TODOs have been resolved
2021-12-01 12:56:41 +09:00
Blaž Hrastnik
8ffafb826f
dap: Rewrite breakpoints so that there's a single set maintained
2021-11-30 17:56:00 +09:00
Blaž Hrastnik
3633f85b38
Pass editor into render_view & gutter, reducing the number of params
2021-11-30 16:47:46 +09:00
Blaž Hrastnik
85b4410703
dap: Toggle breakpoints without changing selection, fix offset calc
2021-11-22 16:30:35 +09:00
Blaž Hrastnik
b55ca8fdb8
dap: Always edit breakpoints on the correct document
2021-11-22 11:22:08 +09:00
Blaž Hrastnik
0eadeab8c7
dap: Remove the prompt line parameter, use insert_str instead
2021-11-22 11:14:10 +09:00
Blaž Hrastnik
5f329a22c4
dap: Modify breakpoints in place with no cloning
2021-11-22 11:09:09 +09:00
Blaž Hrastnik
05d3ad4a0e
dap: Remove an excess clone on enable_exceptions
2021-11-22 00:02:58 +09:00
Blaž Hrastnik
c39d9f44a0
dap: Simplify debug_parameter_prompt
2021-11-07 21:58:06 +09:00
Blaž Hrastnik
3042ff3e5a
dap: Clean up dap_start_impl, no need to clone arg keys
2021-11-07 21:47:44 +09:00
Blaž Hrastnik
9963a5614d
dap: Minor simplifications
2021-11-07 21:37:00 +09:00
Blaž Hrastnik
65868081fc
dap: Simplify launch & start
...
There's no need to re-detect language config, just use the one available
on the document.
2021-11-07 21:26:03 +09:00
Blaž Hrastnik
4f2a01cc09
dap: Error implements Display so we can format with {}
2021-11-07 21:20:58 +09:00
Blaž Hrastnik
2bd8a9b39d
dap: Consistently rename type as ty
2021-11-07 21:18:53 +09:00
Blaž Hrastnik
9dd17c46a2
dap: Avoid cloning old_breakpoints if we are immediately replacing them
2021-11-07 18:58:47 +09:00
Blaž Hrastnik
757babb1b4
dap: Avoid cloning *entire* stack frames when picking a thread
2021-11-07 18:56:09 +09:00
Blaž Hrastnik
5803de2067
dap: Simplify more calls
2021-11-07 18:51:29 +09:00
Blaž Hrastnik
9baddc825d
dap: Get rid of excessive cloning
2021-11-07 18:38:04 +09:00
Blaž Hrastnik
fd9b826f2c
dap: Inline empty completer
2021-11-07 18:15:17 +09:00
Blaž Hrastnik
5938ab1bf1
dap: Fully extract template parameter prompts
2021-11-07 18:13:37 +09:00
Blaž Hrastnik
3b8d5102ac
Make picker take the whole context, not just editor
2021-11-07 18:03:04 +09:00
Blaž Hrastnik
64bb1f7563
dap: Extract out variable rendering
...
Will improve on the UI later
2021-11-07 17:55:01 +09:00
