TudbuT/helix-mods
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

dap: Avoid cloning *entire* stack frames when picking a thread

Browse source
This commit is contained in:
Blaž Hrastnik 2021-11-07 18:56:09 +09:00
parent 5803de2067
commit 757babb1b4
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
helix-term/src/commands/dap.rs
View file

@ -115,7 +115,6 @@ fn thread_picker(cx: &mut Context, callback_fn: impl Fn(&mut Editor, &dap::Threa
}
let thread_states = debugger.thread_states.clone();
let frames = debugger.stack_frames.clone();
let picker = FilePicker::new(
threads,
move |thread| {
@ -129,8 +128,14 @@ fn thread_picker(cx: &mut Context, callback_fn: impl Fn(&mut Editor, &dap::Threa
.into()
},
move |cx, thread, _action| callback_fn(cx.editor, thread),
move |_editor, thread| {
if let Some(frame) = frames.get(&thread.id).and_then(|bt| bt.get(0)) {
move |editor, thread| {
let frame = editor
.debugger
.as_ref()
.and_then(|debugger| debugger.stack_frames.get(&thread.id))
.and_then(|bt| bt.get(0));
if let Some(frame) = frame {
frame
.source
.as_ref()