Document MSRV policy (#3913)

This commit is contained in:
Pascal Kuthe 2022-09-23 08:58:00 +02:00 committed by GitHub
parent eb6fd283dc
commit 4133f1f424
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 15 deletions

View file

@ -1,3 +1,3 @@
[toolchain] [toolchain]
channel = "1.59.0" channel = "1.61.0"
components = ["rustfmt", "rust-src"] components = ["rustfmt", "rust-src"]

7
Cargo.lock generated
View file

@ -485,7 +485,6 @@ dependencies = [
"log", "log",
"once_cell", "once_cell",
"pulldown-cmark", "pulldown-cmark",
"retain_mut",
"serde", "serde",
"serde_json", "serde_json",
"signal-hook", "signal-hook",
@ -884,12 +883,6 @@ dependencies = [
"winapi", "winapi",
] ]
[[package]]
name = "retain_mut"
version = "0.1.9"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "4389f1d5789befaf6029ebd9f7dac4af7f7e3d61b69d4f30e2ac02b57e7712b0"
[[package]] [[package]]
name = "ropey" name = "ropey"
version = "1.5.0" version = "1.5.0"

View file

@ -37,6 +37,12 @@ contributors are strongly encouraged to write integration tests for their code.
Existing tests can be used as examples. Helpers can be found in Existing tests can be used as examples. Helpers can be found in
[helpers.rs][helpers.rs] [helpers.rs][helpers.rs]
## Minimum Stable Rust Version (MSRV) Policy
Helix follows the MSRV of Firefox.
The current MSRV and future changes to the MSRV are listed in the [Firefox documentation].
[Firefox documentation]: https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html
[good-first-issue]: https://github.com/helix-editor/helix/labels/E-easy [good-first-issue]: https://github.com/helix-editor/helix/labels/E-easy
[log-file]: https://github.com/helix-editor/helix/wiki/FAQ#access-the-log-file [log-file]: https://github.com/helix-editor/helix/wiki/FAQ#access-the-log-file
[architecture.md]: ./architecture.md [architecture.md]: ./architecture.md

View file

@ -67,9 +67,6 @@ serde = { version = "1.0", features = ["derive"] }
grep-regex = "0.1.10" grep-regex = "0.1.10"
grep-searcher = "0.1.10" grep-searcher = "0.1.10"
# Remove once retain_mut lands in stable rust
retain_mut = "0.1.7"
[target.'cfg(not(windows))'.dependencies] # https://github.com/vorner/signal-hook/issues/100 [target.'cfg(not(windows))'.dependencies] # https://github.com/vorner/signal-hook/issues/100
signal-hook-tokio = { version = "0.3", features = ["futures-v0_3"] } signal-hook-tokio = { version = "0.3", features = ["futures-v0_3"] }

View file

@ -365,10 +365,6 @@ impl<T: Item> Picker<T> {
.map(|(index, _option)| (index, 0)), .map(|(index, _option)| (index, 0)),
); );
} else if pattern.starts_with(&self.previous_pattern) { } else if pattern.starts_with(&self.previous_pattern) {
// TODO: remove when retain_mut is in stable rust
#[allow(unused_imports, deprecated)]
use retain_mut::RetainMut;
// optimization: if the pattern is a more specific version of the previous one // optimization: if the pattern is a more specific version of the previous one
// then we can score the filtered set. // then we can score the filtered set.
#[allow(unstable_name_collisions)] #[allow(unstable_name_collisions)]