forgejo/models/actions
Jason Song 6844258c67
Clarify Actions resources ownership (#31724)
Fix #31707.

Also related to #31715.

Some Actions resources could has different types of ownership. It could
be:

- global: all repos and orgs/users can use it.
- org/user level: only the org/user can use it.
- repo level: only the repo can use it.

There are two ways to distinguish org/user level from repo level:
1. `{owner_id: 1, repo_id: 2}` for repo level, and `{owner_id: 1,
repo_id: 0}` for org level.
2. `{owner_id: 0, repo_id: 2}` for repo level, and `{owner_id: 1,
repo_id: 0}` for org level.

The first way seems more reasonable, but it may not be true. The point
is that although a resource, like a runner, belongs to a repo (it can be
used by the repo), the runner doesn't belong to the repo's org (other
repos in the same org cannot use the runner). So, the second method
makes more sense.

And the first way is not user-friendly to query, we must set the repo id
to zero to avoid wrong results.

So, #31715 should be right. And the most simple way to fix #31707 is
just:

```diff
-	shared.GetRegistrationToken(ctx, ctx.Repo.Repository.OwnerID, ctx.Repo.Repository.ID)
+	shared.GetRegistrationToken(ctx, 0, ctx.Repo.Repository.ID)
```

However, it is quite intuitive to set both owner id and repo id since
the repo belongs to the owner. So I prefer to be compatible with it. If
we get both owner id and repo id not zero when creating or finding, it's
very clear that the caller want one with repo level, but set owner id
accidentally. So it's OK to accept it but fix the owner id to zero.

(cherry picked from commit a33e74d40d356e8f628ac06a131cb203a3609dec)
2024-08-04 18:24:10 +02:00
..
artifact.go Artifact deletion in actions ui (#27172) 2024-02-23 09:06:14 +01:00
forgejo.go feat(cli): allow updates to runners' secrets 2024-07-22 11:55:43 +02:00
forgejo_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
main_test.go fix(actions): prevent deleted records' UUID from colliding with new records (#3830) 2024-05-19 10:46:15 +00:00
run.go badges: Relax the default workflow badge conditions 2024-05-20 11:20:11 +02:00
run_job.go Replace util.SliceXxx with slices.Xxx (#26958) 2023-09-07 09:37:47 +00:00
run_job_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
run_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
runner.go Clarify Actions resources ownership (#31724) 2024-08-04 18:24:10 +02:00
runner_list.go Refactor more filterslice (gitea#30370) 2024-04-16 11:51:00 +02:00
runner_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
runner_token.go Clarify Actions resources ownership (#31724) 2024-08-04 18:24:10 +02:00
runner_token_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
schedule.go Cancel previous runs of the same PR automatically (#29961) 2024-03-26 16:51:56 +01:00
schedule_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
schedule_spec.go chore(actions): support cron schedule task (#26655) 2023-08-24 03:06:51 +00:00
schedule_spec_list.go [BUG] Add early-return to loading items from SpecList 2024-07-20 01:27:11 +02:00
status.go Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
task.go Fix ambiguous id when fetch Actions tasks (#30382) 2024-04-15 20:01:35 +02:00
task_list.go Drop IDOrderDesc for listing Actions task and always order by id DESC (#31150) 2024-06-02 16:26:54 +02:00
task_output.go Fix no ActionTaskOutput table waring (#28149) 2023-11-21 08:02:51 +00:00
task_step.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
tasks_version.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
utils.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
utils_test.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
variable.go Clarify Actions resources ownership (#31724) 2024-08-04 18:24:10 +02:00