bb2783860b
`repoCtx.CommitsCount` is not reliably the commit count of the default branch (Repository.GetCommitsCount depends on what is currently displayed). For instance on the releases page the commit count is correct: https://codeberg.org/Codeberg/pages-server/releases ![2023-04-15-215027](https://user-images.githubusercontent.com/3864879/232250500-6c05dc00-7030-4ec9-87f1-18c7797d36bf.png) However it is not on the single page: https://codeberg.org/Codeberg/pages-server/releases/tag/v4.6.2 ![2023-04-15-215036](https://user-images.githubusercontent.com/3864879/232250503-620c8038-7c2c-45a1-b99d-cb994ef955a6.png) This PR fixes this by removing a "fast branch" which was using this field (I think this field should be removed, since it is a bit unpredictable - but this would mean a larger refactoring PR). _contributed in the context of @forgejo_ --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
48 lines
1.1 KiB
Go
48 lines
1.1 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package db_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
type mockListOptions struct {
|
|
db.ListOptions
|
|
}
|
|
|
|
func (opts *mockListOptions) IsListAll() bool {
|
|
return true
|
|
}
|
|
|
|
func (opts *mockListOptions) ToConds() builder.Cond {
|
|
return builder.NewCond()
|
|
}
|
|
|
|
func TestFind(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
xe := unittest.GetXORMEngine()
|
|
assert.NoError(t, xe.Sync(&repo_model.RepoUnit{}))
|
|
|
|
opts := mockListOptions{}
|
|
var repoUnits []repo_model.RepoUnit
|
|
err := db.Find(db.DefaultContext, &opts, &repoUnits)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 89, len(repoUnits))
|
|
|
|
cnt, err := db.Count(db.DefaultContext, &opts, new(repo_model.RepoUnit))
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 89, cnt)
|
|
|
|
repoUnits = make([]repo_model.RepoUnit, 0, 10)
|
|
newCnt, err := db.FindAndCount(db.DefaultContext, &opts, &repoUnits)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, cnt, newCnt)
|
|
}
|