TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
forgejo/models
History
Jason Song a35714372d
Fix halfCommitter and WithTx (#22366) 
Related to #22362.

I overlooked that there's always `committer.Close()`, like:

```go
		ctx, committer, err := db.TxContext(db.DefaultContext)
		if err != nil {
			return nil
		}
		defer committer.Close()

		// ...

		if err != nil {
			return nil
		}

		// ...

		return committer.Commit()
```

So the `Close` of `halfCommitter` should ignore `commit and close`, it's
not a rollback.

See: [Why `halfCommitter` and `WithTx` should rollback IMMEDIATELY or
commit
LATER](https://github.com/go-gitea/gitea/pull/22366#issuecomment-1374778612).

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-01-09 12:19:19 -05:00
..
activities Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
admin Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
asymkey Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
auth Use random bytes to generate access token (#21959) 2022-11-28 23:37:42 +08:00
avatars Fix get system setting bug when enabled redis cache (#22295) 2023-01-02 00:06:52 +08:00
db Fix halfCommitter and WithTx (#22366) 2023-01-09 12:19:19 -05:00
fixtures Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
git Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
issues Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
migrations Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
organization Secrets storage with SecretKey encrypted (#22142) 2022-12-20 17:07:13 +08:00
packages Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
perm Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
project Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
pull refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
secret Secrets storage with SecretKey encrypted (#22142) 2022-12-20 17:07:13 +08:00
system Fix set system setting failure once it cached (#22333) 2023-01-08 21:22:41 +08:00
unit Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
unittest Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
user Fix get system setting bug when enabled redis cache (#22295) 2023-01-02 00:06:52 +08:00
webhook Remove old HookEventType (#22358) 2023-01-06 19:49:14 +08:00
error.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fixture_generation.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fixture_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
migrate.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
migrate_test.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
org.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
org_team.go Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
org_team_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Secrets storage with SecretKey encrypted (#22142) 2022-12-20 17:07:13 +08:00
repo_collaboration.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo_collaboration_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_transfer.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
repo_transfer_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
user.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00