83d2b3b7fa
UX/Translation changes: - new teams: remove redundant tooltips that don't add meaningful information - move general information to table fieldset - new teams: rename "general" to "custom" access for clarity - new teams: show labels beside options on mobile Accessibility: - semantic form elements allow easier navigation (fieldset, mostly) - improve better labelling of new teams table - fix accessibility scan issues - TODO: the parts that "disable" form elements were not yet touched and are not really accessible to screenreaders Technical: - replace two JavaScript solutions with one CSS standard - implement a simpler grid (.simple-grid) - simplify markup - remove some webhook settings specific CSS Testing: - check more form content for accessibility issues - but exclude tooltips from the scan :( - reuse existing form tests from previous PR
147 lines
7.2 KiB
Go HTML Template
147 lines
7.2 KiB
Go HTML Template
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content organization new team">
|
|
{{template "org/header" .}}
|
|
<div class="ui container">
|
|
<div class="ui grid">
|
|
<div class="column">
|
|
<form class="ui form" action="{{if .PageIsOrgTeamsNew}}{{.OrgLink}}/teams/new{{else}}{{.OrgLink}}/teams/{{.Team.LowerName | PathEscape}}/edit{{end}}" data-delete-url="{{.OrgLink}}/teams/{{.Team.LowerName | PathEscape}}/delete" method="post">
|
|
{{.CsrfTokenHtml}}
|
|
<h3 class="ui top attached header">
|
|
{{if .PageIsOrgTeamsNew}}{{ctx.Locale.Tr "org.create_new_team"}}{{else}}{{ctx.Locale.Tr "org.teams.settings"}}{{end}}
|
|
</h3>
|
|
<div class="ui attached segment">
|
|
{{template "base/alert" .}}
|
|
<div class="required field {{if .Err_TeamName}}error{{end}}">
|
|
<label for="team_name">{{ctx.Locale.Tr "org.team_name"}}</label>
|
|
{{if eq .Team.LowerName "owners"}}
|
|
<input type="hidden" name="team_name" value="{{.Team.Name}}">
|
|
{{end}}
|
|
<input id="team_name" name="team_name" value="{{.Team.Name}}" required {{if eq .Team.LowerName "owners"}}disabled{{end}} autofocus>
|
|
<span class="help">{{ctx.Locale.Tr "org.team_name_helper"}}</span>
|
|
</div>
|
|
<div class="field {{if .Err_Description}}error{{end}}">
|
|
<label for="description">{{ctx.Locale.Tr "org.team_desc"}}</label>
|
|
<input id="description" name="description" value="{{.Team.Description}}">
|
|
<span class="help">{{ctx.Locale.Tr "org.team_desc_helper"}}</span>
|
|
</div>
|
|
{{if not (eq .Team.LowerName "owners")}}
|
|
<fieldset>
|
|
<legend>{{ctx.Locale.Tr "org.team_access_desc"}}</legend>
|
|
<label>
|
|
<input type="radio" name="repo_access" value="specific" {{if not .Team.IncludesAllRepositories}}checked{{end}}>
|
|
{{ctx.Locale.Tr "org.teams.specific_repositories"}}
|
|
<span class="help">{{ctx.Locale.Tr "org.teams.specific_repositories_helper"}}</span>
|
|
</label>
|
|
<label>
|
|
<input type="radio" name="repo_access" value="all" {{if .Team.IncludesAllRepositories}}checked{{end}}>
|
|
{{ctx.Locale.Tr "org.teams.all_repositories"}}
|
|
<span class="help">{{ctx.Locale.Tr "org.teams.all_repositories_helper"}}</span>
|
|
</label>
|
|
|
|
<label>
|
|
<input name="can_create_org_repo" type="checkbox" {{if .Team.CanCreateOrgRepo}}checked{{end}}>
|
|
{{ctx.Locale.Tr "org.teams.can_create_org_repo"}}
|
|
<span class="help">{{ctx.Locale.Tr "org.teams.can_create_org_repo_helper"}}</span>
|
|
</label>
|
|
</fieldset>
|
|
<fieldset>
|
|
<legend>{{ctx.Locale.Tr "org.team_permission_desc"}}</legend>
|
|
<label>
|
|
<input type="radio" name="permission" value="admin" {{if eq .Team.AccessMode 3}}checked{{end}}>
|
|
{{ctx.Locale.Tr "org.teams.admin_access"}}
|
|
<span class="help">{{ctx.Locale.Tr "org.teams.admin_access_helper"}}</span>
|
|
</label>
|
|
<label>
|
|
<input type="radio" name="permission" value="read" {{if or .PageIsOrgTeamsNew (eq .Team.AccessMode 1) (eq .Team.AccessMode 2)}}checked{{end}}>
|
|
{{ctx.Locale.Tr "org.teams.general_access"}}
|
|
<span class="help">{{ctx.Locale.Tr "org.teams.general_access_helper"}}</span>
|
|
</label>
|
|
<fieldset class="hide-unless-checked">
|
|
<legend>{{ctx.Locale.Tr "org.team_unit_desc"}}
|
|
<span class="help">{{ctx.Locale.Tr "org.teams.none_access_helper"}}</span>
|
|
</legend>
|
|
<table class="ui table optionmatrix">
|
|
<thead>
|
|
<tr>
|
|
<th>{{ctx.Locale.Tr "units.unit"}}</th>
|
|
<th id="access_none">{{ctx.Locale.Tr "org.teams.none_access"}}</th>
|
|
<th id="access_read">{{ctx.Locale.Tr "org.teams.read_access"}}</th>
|
|
<th id="access_write">{{ctx.Locale.Tr "org.teams.write_access"}}</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{{range $t, $unit := $.Units}}
|
|
{{if ge $unit.MaxPerm 2}}
|
|
<tr>
|
|
<td>
|
|
<label {{if $unit.Type.UnitGlobalDisabled}} data-tooltip-content="{{ctx.Locale.Tr "repo.unit_disabled"}}"{{end}}>
|
|
{{ctx.Locale.Tr $unit.NameKey}}{{if $unit.Type.UnitGlobalDisabled}} {{ctx.Locale.Tr "org.team_unit_disabled"}}{{end}}
|
|
<span class="help">{{ctx.Locale.Tr $unit.DescKey}}</span>
|
|
</label>
|
|
</td>
|
|
<td>
|
|
<label>
|
|
<input aria-labelledby="access_none" type="radio" name="unit_{{$unit.Type.Value}}" value="0"{{if or ($unit.Type.UnitGlobalDisabled) (eq ($.Team.UnitAccessMode $.Context $unit.Type) 0)}} checked{{end}}>
|
|
<span class="only-mobile">{{ctx.Locale.Tr "org.teams.none_access"}}</span>
|
|
</label>
|
|
</td>
|
|
<td>
|
|
<label>
|
|
<input aria-labelledby="access_read" type="radio" name="unit_{{$unit.Type.Value}}" value="1"{{if or (eq $.Team.ID 0) (eq ($.Team.UnitAccessMode $.Context $unit.Type) 1)}} checked{{end}} {{if $unit.Type.UnitGlobalDisabled}}disabled{{end}}>
|
|
<span class="only-mobile">{{ctx.Locale.Tr "org.teams.read_access"}}</span>
|
|
</label>
|
|
</td>
|
|
<td>
|
|
<label>
|
|
<input aria-labelledby="access_write" type="radio" name="unit_{{$unit.Type.Value}}" value="2"{{if (ge ($.Team.UnitAccessMode $.Context $unit.Type) 2)}} checked{{end}} {{if $unit.Type.UnitGlobalDisabled}}disabled{{end}}>
|
|
<span class="only-mobile">{{ctx.Locale.Tr "org.teams.write_access"}}</span>
|
|
</label>
|
|
</td>
|
|
</tr>
|
|
{{end}}
|
|
{{end}}
|
|
</tbody>
|
|
</table>
|
|
<fieldset>
|
|
{{range $t, $unit := $.Units}}
|
|
{{if lt $unit.MaxPerm 2}}
|
|
<label {{if $unit.Type.UnitGlobalDisabled}}data-tooltip-content="{{ctx.Locale.Tr "repo.unit_disabled"}}"{{end}}>
|
|
<input type="checkbox" name="unit_{{$unit.Type.Value}}" value="1"{{if or (eq $.Team.ID 0) (eq ($.Team.UnitAccessMode $.Context $unit.Type) 1)}} checked{{end}} {{if $unit.Type.UnitGlobalDisabled}}disabled{{end}}>
|
|
{{ctx.Locale.Tr $unit.NameKey}}{{if $unit.Type.UnitGlobalDisabled}} {{ctx.Locale.Tr "org.team_unit_disabled"}}{{end}}
|
|
<span class="help">{{ctx.Locale.Tr $unit.DescKey}}</span>
|
|
</label>
|
|
{{end}}
|
|
{{end}}
|
|
</fieldset>
|
|
</fieldset>
|
|
</fieldset>
|
|
{{end}}
|
|
|
|
<div class="field">
|
|
{{if .PageIsOrgTeamsNew}}
|
|
<button class="ui primary button">{{ctx.Locale.Tr "org.create_team"}}</button>
|
|
{{else}}
|
|
<button class="ui primary button">{{ctx.Locale.Tr "org.teams.update_settings"}}</button>
|
|
{{if not (eq .Team.LowerName "owners")}}
|
|
<button class="ui red button delete-button" data-url="{{.OrgLink}}/teams/{{.Team.Name | PathEscape}}/delete">{{ctx.Locale.Tr "org.teams.delete_team"}}</button>
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="ui g-modal-confirm delete modal">
|
|
<div class="header">
|
|
{{svg "octicon-trash"}}
|
|
{{ctx.Locale.Tr "org.teams.delete_team_title"}}
|
|
</div>
|
|
<div class="content">
|
|
<p>{{ctx.Locale.Tr "org.teams.delete_team_desc"}}</p>
|
|
</div>
|
|
{{template "base/modal_actions_confirm" .}}
|
|
</div>
|
|
{{template "base/footer" .}}
|