21cd5c2f3d
Backport #23911 by @lunny Follow up #22405 Fix #20703 This PR rewrites storage configuration read sequences with some breaks and tests. It becomes more strict than before and also fixed some inherit problems. - Move storage's MinioConfig struct into setting, so after the configuration loading, the values will be stored into the struct but not still on some section. - All storages configurations should be stored on one section, configuration items cannot be overrided by multiple sections. The prioioty of configuration is `[attachment]` > `[storage.attachments]` | `[storage.customized]` > `[storage]` > `default` - For extra override configuration items, currently are `SERVE_DIRECT`, `MINIO_BASE_PATH`, `MINIO_BUCKET`, which could be configured in another section. The prioioty of the override configuration is `[attachment]` > `[storage.attachments]` > `default`. - Add more tests for storages configurations. - Update the storage documentations. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
47 lines
1.1 KiB
Go
47 lines
1.1 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_11 //nolint
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"xorm.io/builder"
|
|
"xorm.io/xorm"
|
|
)
|
|
|
|
func RemoveAttachmentMissedRepo(x *xorm.Engine) error {
|
|
type Attachment struct {
|
|
UUID string `xorm:"uuid"`
|
|
}
|
|
var start int
|
|
attachments := make([]*Attachment, 0, 50)
|
|
for {
|
|
err := x.Select("uuid").Where(builder.NotIn("release_id", builder.Select("id").From("`release`"))).
|
|
And("release_id > 0").
|
|
OrderBy("id").Limit(50, start).Find(&attachments)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for i := 0; i < len(attachments); i++ {
|
|
uuid := attachments[i].UUID
|
|
if err = util.RemoveAll(filepath.Join(setting.Attachment.Storage.Path, uuid[0:1], uuid[1:2], uuid)); err != nil {
|
|
fmt.Printf("Error: %v", err) //nolint:forbidigo
|
|
}
|
|
}
|
|
|
|
if len(attachments) < 50 {
|
|
break
|
|
}
|
|
start += 50
|
|
attachments = attachments[:0]
|
|
}
|
|
|
|
_, err := x.Exec("DELETE FROM attachment WHERE release_id > 0 AND release_id NOT IN (SELECT id FROM `release`)")
|
|
return err
|
|
}
|