Brecht Van Lommel
e541a8c654
Make mention autocomplete case insensitive in new markdown editor ( #24190 )
...
This matches EasyMDE, and makes it easier to find the right user without
having to remember the exact name.
---------
Co-authored-by: silverwind <me@silverwind.io>
2023-04-18 13:25:11 -04:00
Hester Gong
7ca7590c39
Fix duplicate modals when clicking on "remove all" repository button ( #24129 )
...
Under Team tab of an organization, click on "remove all" repositories
button will trigger two modals. Because `data-modal-id` is not proerly
added.
Before:
https://user-images.githubusercontent.com/17645053/231988545-ac690b86-e3fe-4bf5-81c6-5ef09302e849.mov
After:
https://user-images.githubusercontent.com/17645053/231989678-53be4f91-fdc9-4bc5-ba11-a08aa4548e37.mov
2023-04-19 00:49:49 +08:00
Yarden Shoham
2002584986
Bump GitHub's relative-time-element to v4.3.0 ( #24187 )
...
https://github.com/github/relative-time-element/releases/tag/v4.3.0
I checked and everything still works
2023-04-19 00:00:01 +08:00
Hester Gong
6f3c162f48
Fix wrong scopes of locale.PrettyNumber ( #24181 )
2023-04-18 19:26:57 +08:00
wxiaoguang
2979041bc5
Fix incorrect internal response type ( #24173 )
...
Close #24167
The endpoint "set-default-branch" returns `success`, so just decode it
as `responseText`
2023-04-17 23:10:40 -04:00
Kroytz
f82ee30097
zh-cn support on doc pages ( #24166 )
...
+ Add zh-cn support for upgrade-from-gitea page
+ Fix typo error on https-support.zh-cn page
2023-04-18 08:23:35 +08:00
GiteaBot
6f86b98ded
[skip ci] Updated translations via Crowdin
2023-04-18 00:07:34 +00:00
Panagiotis "Ivory" Vasilopoulos
2ef6ac8dbf
Use double quotes consistently in en-US ( #24141 )
...
Also removes quotes in commit messages related to file modifications
made in the Web UI.
2023-04-17 18:04:26 -04:00
John Olheiser
9611710636
Use correct locale key for forks page ( #24172 )
...
4014200021/options/locale/locale_en-US.ini (L873)4014200021/options/locale/locale_en-US.ini (L943)
2023-04-17 15:41:06 -05:00
wxiaoguang
1ab16e48cc
Improve Wiki TOC ( #24137 )
...
The old code has a lot of technical debts, eg: `repo/wiki/view.tmpl` /
`Iterate`
This PR improves the Wiki TOC display and improves the code.
---------
Co-authored-by: delvh <dev.lh@web.de>
2023-04-17 15:05:19 -04:00
Yarden Shoham
f045e58cc7
Localize activity heatmap (except tooltip) ( #24131 )
...
The calculation of the total sum is moved to the backend so a full HTML
string could be sent.
- Closes #10669
- 2nd attempt (the first was in #21570 )
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
2023-04-17 14:26:01 -04:00
Zettat123
5eb4c63867
Support triggering workflows by wiki related events ( #24119 )
...
This PR is to support triggering workflows by wiki related events like
creating, editing or deleting wiki pages. In GitHub, this event is
called
[gollum](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#gollum )
2023-04-17 13:49:47 -04:00
techknowlogick
4014200021
add CLI command to register runner tokens ( #23762 )
...
This is a CLI command to generate new tokens for the runners to register
with
Fix https://github.com/go-gitea/gitea/issues/23643
---------
Co-authored-by: delvh <dev.lh@web.de>
2023-04-17 13:07:13 -04:00
techknowlogick
1819c4b59b
Add new user types reserved, bot, and remote ( #24026 )
...
This allows for usernames, and emails connected to them to be reserved
and not reused.
Use case, I manage an instance with open registration, and sometimes
when users are deleted for spam (or other purposes), their usernames are
freed up and they sign up again with the same information.
This could also be used to reserve usernames, and block them from being
registered (in case an instance would like to block certain things
without hardcoding the list in code and compiling from scratch).
This is an MVP, that will allow for future work where you can set
something as reserved via the interface.
---------
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
2023-04-17 12:36:50 -04:00
wxiaoguang
f20057271d
Fix Org edit page bugs: renaming detection, maxlength ( #24161 )
...
## Before
* The renaming detection is wrong (eg: pasting a new name into the input
doesn't trigger the detection)
* The renaming prompt layout is not good
* Some MaxSize/maxlength rules is missing
## After
* Fix these problems
2023-04-17 11:35:57 -04:00
silverwind
4b1c6cd8e5
Make HAS_GO a simply expanded variable ( #24169 )
...
Avoid recursive expansion on this variable and simplify the value.
[Reference](https://www.gnu.org/software/make/manual/html_node/Setting.html ).
2023-04-17 10:46:25 -04:00
Lunny Xiao
cda84bec87
Support converting varchar to nvarchar for mssql database ( #24105 )
2023-04-17 21:22:10 +08:00
silverwind
dcde4701a5
Fix math and mermaid rendering bugs ( #24049 )
...
1. Fix multiple error display for math and mermaid:
2. Fix height calculation of certain mermaid diagrams by reading the
iframe inner height from it's document instead of parsing it from SVG:
Before:
<img width="866" alt="Screenshot 2023-04-11 at 11 56 27"
src="https://user-images.githubusercontent.com/115237/231126480-b194e02b-ea8c-4ddf-8c79-50c525815d92.png ">
After:
<img width="855" alt="Screenshot 2023-04-11 at 11 56 35"
src="https://user-images.githubusercontent.com/115237/231126494-5fe86a48-8d21-455a-8b95-79b6ee27a16f.png ">
3. Refactor error handling to a common function
4. Rename to `renderAsciicast` for consistency
5. Improve mermaid loading sequence
Note: I did try `securityLevel: 'sandbox'` to make mermaid output a
iframe directly, but that showed a bug in mermaid where the iframe style
height was set incorrectly. Opened
https://github.com/mermaid-js/mermaid/issues/4289 for this.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2023-04-17 12:10:22 +02:00
wxiaoguang
7681d582cd
Refactor locale number ( #24134 )
...
Before, the `GiteaLocaleNumber.js` was just written as a a drop-in
replacement for old `js-pretty-number`.
Actually, we can use Golang's `text` package to format.
This PR partially completes the TODOs in `GiteaLocaleNumber.js`:
> if we have complete backend locale support (eg: Golang "x/text"
package), we can drop this component.
> tooltip: only 2 usages of this, we can replace it with Golang's
"x/text/number" package in the future.
This PR also helps #24131
Screenshots:
<details>
</details>
2023-04-17 11:37:23 +08:00
GiteaBot
be7cd73439
[skip ci] Updated translations via Crowdin
2023-04-17 00:07:34 +00:00
wxiaoguang
685b0ffa19
Use 1.18's aria role for dropdown menus ( #24144 )
...
According to erion's feedback, the 1.18 approach works with Safari
(`role=menu` on the parent container), while the 1.19's approach doesn't
work well with Safari+VoiceOver (although I tested it worked with Chrome
a little better).
I have tested this 1.18 approach could work for all
Safari/Chrome+VoiceOver and Chrome+Talkback.
Let's try to make it on try.gitea.io to see whether it helps Safari
users.
2023-04-16 21:58:22 +08:00
wxiaoguang
0e05984667
Set EasyMDE heading font-size to the same size as the resulting markdown ( #24151 )
...
Fix #23816
According to my personal experience, the EasyMDE is still useful when
writing a lot of contents, eg: the wiki page.
It's not difficult to improve its heading styles, so let's make it.
Before:
<img width="815" alt="image"
src="https://user-images.githubusercontent.com/2114189/232280943-9177f0bc-e380-426f-8588-20ff8d8e5293.png ">
After:
<img width="538" alt="image"
src="https://user-images.githubusercontent.com/2114189/232280903-e8c476ee-f5b1-48fe-8a93-86fcd79680c3.png ">
2023-04-16 20:01:08 +08:00
Jonathan Tran
1af3dc6ee3
Fix 2-dot direct compare to use the right base commit ( #24133 )
...
For 2-dot direct compare, we should use the base commit in the title and
templates, as is used elsewhere, not the common ancestor which is used
for 3-dot compare. I believe that this change should have been included
in #22949 .
2023-04-16 10:27:23 +03:00
yp05327
fa3495183b
Add migration to fix external unit access mode of owner/admin team ( #24117 )
...
Fix the incorrect migration in #23675 and #24012
External Unit (Tracker and Wiki) access mode should be `read` in
owner/admin team.
2023-04-15 09:52:44 -04:00
Yarden Shoham
b4e952545b
Remove untranslatable on_date key ( #24106 )
...
- Follows #23988
- Fixes : #24074 by removing this key
GitHub's `relative-time` elements allow us to force their rendering to
`auto`, `past`, or `future` tense. We will never show an absolute date
`on ...` in `TimeSince`
## Before
## After
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-04-15 13:01:54 +02:00
GiteaBot
35e562d7bd
[skip ci] Updated translations via Crowdin
2023-04-15 00:07:26 +00:00
wxiaoguang
2902d1e9d1
Sort repo topic labels by name ( #24123 )
...
Close #24077
2023-04-14 15:29:05 -04:00
Tyrone Yeh
ed81b608cb
Add option to search for users is active join a team ( #24093 )
...
Adding a user in a team to enter a username gives a list of no active
users
---------
Co-authored-by: Jason Song <i@wolfogre.com>
2023-04-14 14:48:36 -04:00
wxiaoguang
cfe3d6e9b5
Make more functions use ctx instead of db.DefaultContext ( #24068 )
...
Continue the "ctx refactoring" work.
There are still a lot db.DefaultContext, incorrect context could cause
database deadlock errors.
2023-04-14 14:18:28 -04:00
Brecht Van Lommel
b667634b32
Fix meilisearch not working when searching across multiple repositories ( #24109 )
...
This would happen in the issue and pull request dashboards, while the
per repository lists worked fine.
Use OR instead of AND for repo IDs.
2023-04-14 13:27:11 -04:00
wxiaoguang
1c8bc4081a
Show friendly 500 error page to users and developers ( #24110 )
...
Close #24104
This also introduces many tests to cover many complex error handling
functions.
### Before
The details are never shown in production.
<details>
</details>
### After
The details could be shown to site admin users. It is safe.
2023-04-14 13:19:11 +08:00
yp05327
5768bafeb2
Fix incorrect server error content in RunnersList ( #24118 )
2023-04-14 11:34:10 +08:00
GiteaBot
5f4cd715ab
[skip ci] Updated translations via Crowdin
2023-04-14 00:07:25 +00:00
wxiaoguang
334c899f7b
Improve git log for debugging ( #24095 )
2023-04-13 19:17:27 -04:00
techknowlogick
985f76dc4b
Update redis library to support redis v7 ( #24114 )
2023-04-13 18:41:04 -04:00
wxiaoguang
5b9557aef5
Refactor cookie ( #24107 )
...
Close #24062
At the beginning, I just wanted to fix the warning mentioned by #24062
But, the cookie code really doesn't look good to me, so clean up them.
Complete the TODO on `SetCookie`:
> TODO: Copied from gitea.com/macaron/macaron and should be improved
after macaron removed.
2023-04-13 15:45:33 -04:00
yp05327
b7221bec34
Fix admin team access mode value in team_unit table ( #24012 )
...
Same as https://github.com/go-gitea/gitea/pull/23675
Feedback:
https://github.com/go-gitea/gitea/pull/23879#issuecomment-1500923636
2023-04-13 21:06:10 +02:00
silverwind
469dc4459b
Add monospace toggle button to textarea ( #24034 )
...
- Add new button to textarea to switch font. State is persisted in
localStorage.
- Change markdown-switch-easymde button from `<span>` to `<button>`
- Slightly increased monospace font globally by 5% as I think it fits
better.
For hover effect on these buttons I'm deferring to
https://github.com/go-gitea/gitea/pull/23896 .
---------
Co-authored-by: delvh <dev.lh@web.de>
2023-04-13 15:05:06 -04:00
Gary Moon
29194a9dd6
Correct the access log format ( #24085 )
...
The default access log format has been unnecessarily escaped, leading to
spurious backslashes appearing in log lines.
Additionally, the `RemoteAddr` field includes the port, which breaks
most log parsers attempting to process it. I've added a call to
`net.SplitHostPort()` attempting to isolate the address alone, with a
fallback to the original address if it errs.
Signed-off-by: Gary Moon <gary@garymoon.net>
2023-04-13 21:14:06 +08:00
6543
2b749af505
Changelog v1.19.1 ( #24079 ) ( #24092 )
...
Frontport #24079
2023-04-13 16:45:54 +08:00
GiteaBot
4299c3b7db
[skip ci] Updated translations via Crowdin
2023-04-13 00:07:24 +00:00
dependabot[bot]
8d21b6925f
Bump vm2 from 3.9.15 to 3.9.16 ( #24089 )
...
Bumps [vm2](https://github.com/patriksimek/vm2 ) from 3.9.15 to 3.9.16.
Signed-off-by: dependabot[bot] <support@github.com>
2023-04-12 17:45:39 -04:00
Lunny Xiao
622d549ba2
Fix difficult translation for other languages ( #24070 )
...
Fix https://github.com/go-gitea/gitea/pull/24051#discussion_r1163697643
---------
Co-authored-by: silverwind <me@silverwind.io>
2023-04-12 13:05:53 -04:00
Zettat123
2d91afaa92
Fix mismatch between hook events and github event types ( #24048 )
...
Some workflow trigger events can have multiple activity types, such as
`issues` and `pull_request`, and user can specify which types can
trigger the workflow. See GitHub documentation:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
Now some hook events cannot match the workflow trigger events correctly
because we don't check the activity types. For example,
`pull_request_label` is an individual hook event. But there isn't a
`pull_request_label` workflow trigger event, we can only use
`pull_request` event's `label` activity type. If we don't check the
activity types, the workflows without the `label` activity type may be
triggered by the `pull_request_label` event by mistake. We need to
improve the match logic.
- [x] [`issues`
](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issues )
- [x]
[`issue_comment`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment )
- [x]
[`pull_request`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request )
- [x]
[`pull_request_review`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review )
- [x]
[`pull_request_review_comment`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review_comment )
- [x]
[`release`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release )
- [x]
[`registry_package`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#registry_package )
2023-04-12 12:16:47 -04:00
wxiaoguang
53e324fd80
Improve LFS error logs ( #24072 )
...
The error logs were not clear.
Help (but not fix) #24053
2023-04-12 11:01:41 -04:00
sillyguodong
3753ecd583
Update the value of the diffEnd when click Show More btn in the DiffFileTree ( #24069 )
...
In the component `DiffFileTree`,if don't update the value of the
`diffEnd` in the callback of ajax request, click `Show More` btn will
always return the same response, duplicate files are appended to the
file list.
Before:
https://user-images.githubusercontent.com/33891828/231371188-82d169af-10bb-47e2-8aca-83ced2597f2d.mov
After:
https://user-images.githubusercontent.com/33891828/231369805-39a5a4d0-662c-4f08-bc5a-7d31e8782453.mov
---------
Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-04-12 15:11:23 +02:00
delvh
58b36cc422
Add tooltips to Hide comment type settings where necessary ( #21306 )
...
Previously, this setting was pretty confusing for users, especially the
difference between "reference" and "issue reference".
Related: #21321 .
2023-04-12 19:59:17 +08:00
wxiaoguang
50a72e7a83
Use a general approach to access custom/static/builtin assets ( #24022 )
...
The idea is to use a Layered Asset File-system (modules/assetfs/layered.go)
For example: when there are 2 layers: "custom", "builtin", when access
to asset "my/page.tmpl", the Layered Asset File-system will first try to
use "custom" assets, if not found, then use "builtin" assets.
This approach will hugely simplify a lot of code, make them testable.
Other changes:
* Simplify the AssetsHandlerFunc code
* Simplify the `gitea embedded` sub-command code
---------
Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-04-12 18:16:45 +08:00
JakobDev
42919ccb7c
Make Release Download URLs predictable ( #23891 )
...
As promised in #23817 , I have this made a PR to make Release Download
URLs predictable. It currently follows the schema
`<repo>/releases/download/<tag>/<filename>`. this already works, but it
is nowhere shown in the UI or the API. The Problem is, that it is
currently possible to have multiple files with the same name (why do we
even allow this) for a release. I had written some Code to check, if a
Release has 2 or more files with the same Name. If yes, it uses the old
`attachments/<uuid>` URlL if no it uses the new fancy URL.
I had also changed `<repo>/releases/download/<tag>/<filename>` to
directly serve the File instead of redirecting, so people who who use
automatic update checker don't end up with the `attachments/<uuid>` URL.
Fixes #10919
---------
Co-authored-by: a1012112796 <1012112796@qq.com>
2023-04-12 17:05:23 +08:00
sillyguodong
e03e827dcb
Expand selected file when clicking file tree ( #24041 )
...
Auto expand the selected file when clicking the file item of the file
tree.
This is consistent with Github's behavior.
https://user-images.githubusercontent.com/33891828/231048124-61f180af-adba-42d7-9ffa-626e1de04aed.mov
2023-04-12 15:06:39 +08:00
