From f56bba1a7823168f038cc4bd847c51771ca73bc9 Mon Sep 17 00:00:00 2001 From: Gusted Date: Sun, 27 Feb 2022 15:49:22 +0000 Subject: [PATCH] Fix trace log to show value instead of pointers (#18926) - Fixes a issue with a trace of repo.Units whereby it would show the pointers. Before: ![image](https://user-images.githubusercontent.com/25481501/155876811-036bf40e-db89-4e09-ac00-0c78ce3f5bef.png) After: ![image](https://user-images.githubusercontent.com/25481501/155885102-16c9cf29-314b-4f32-bcee-80e332f63dec.png) --- models/repo/repo.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/models/repo/repo.go b/models/repo/repo.go index 28d976773d..156ead405d 100644 --- a/models/repo/repo.go +++ b/models/repo/repo.go @@ -290,7 +290,14 @@ func (repo *Repository) LoadUnits(ctx context.Context) (err error) { } repo.Units, err = getUnitsByRepoID(db.GetEngine(ctx), repo.ID) - log.Trace("repo.Units: %-+v", repo.Units) + if log.IsTrace() { + unitTypeStrings := make([]string, len(repo.Units)) + for i, unit := range repo.Units { + unitTypeStrings[i] = unit.Type.String() + } + log.Trace("repo.Units, ID=%d, Types: [%s]", repo.ID, strings.Join(unitTypeStrings, ", ")) + } + return err }