TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Remove jQuery from the issue reference context popup (#29367)

Browse source 
- Removed all jQuery calls
- Tested the context popup functionality and it works as before

# Demo without jQuery

![action](https://github.com/go-gitea/gitea/assets/20454870/90b53de5-a8e9-4ed7-9236-1c9dfc324f38)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 267dbb4e938cc42dc09a4a893cca631b2f755557)
This commit is contained in:
Yarden Shoham 2024-02-24 14:03:53 +02:00 committed by Earl Warren
parent 64ef7d3658
commit e91b948613
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
web_src/js/components/ContextPopup.vue
View file

@ -1,8 +1,8 @@
<script> <script>
import $ from 'jquery';
import {SvgIcon} from '../svg.js'; import {SvgIcon} from '../svg.js';
import {useLightTextOnBackground} from '../utils/color.js'; import {useLightTextOnBackground} from '../utils/color.js';
import tinycolor from 'tinycolor2'; import tinycolor from 'tinycolor2';
import {GET} from '../modules/fetch.js';
const {appSubUrl, i18n} = window.config; const {appSubUrl, i18n} = window.config;
@ -80,20 +80,23 @@ export default {
}); });
}, },
methods: { methods: {
load(data) { async load(data) {
this.loading = true; this.loading = true;
this.i18nErrorMessage = null; this.i18nErrorMessage = null;
$.get(`${appSubUrl}/${data.owner}/${data.repo}/issues/${data.index}/info`).done((issue) => {
this.issue = issue; try {
}).fail((jqXHR) => { const response = await GET(`${appSubUrl}/${data.owner}/${data.repo}/issues/${data.index}/info`);
if (jqXHR.responseJSON && jqXHR.responseJSON.message) { const respJson = await response.json();
this.i18nErrorMessage = jqXHR.responseJSON.message; if (!response.ok) {
} else { this.i18nErrorMessage = respJson.message ?? i18n.network_error;
this.i18nErrorMessage = i18n.network_error; return;
} }
}).always(() => { this.issue = respJson;
} catch {
this.i18nErrorMessage = i18n.network_error;
} finally {
this.loading = false; this.loading = false;
}); }
} }
} }
}; };