TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't select join table's columns (#19660)

Browse source 
* Don't select join table

* Add comment
This commit is contained in:
Lunny Xiao 2022-05-09 23:19:16 +08:00 • committed by GitHub
parent cd99540cdc
commit e435283c0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
models/action.go
View file

@ -340,7 +340,9 @@ func GetFeeds(ctx context.Context, opts GetFeedsOptions) (ActionList, error) {
} }
e := db.GetEngine(ctx) e := db.GetEngine(ctx)
sess := e.Where(cond).Join("INNER", "repository", "`repository`.id = `action`.repo_id") sess := e.Where(cond).
Select("`action`.*"). // this line will avoid select other joined table's columns
Join("INNER", "repository", "`repository`.id = `action`.repo_id")
opts.SetDefaultValues() opts.SetDefaultValues()
sess = db.SetSessionPagination(sess, &opts) sess = db.SetSessionPagination(sess, &opts)