TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix: http: multiple response.WriteHeader calls (#2038)

Browse source 
We can't change the http status code here, because the response has been written.
This commit is contained in:
Shuanglei Tao 2017-06-28 14:08:47 +08:00 • committed by Lunny Xiao
parent 32fc44aa83
commit d389ed25a5
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
routers/repo/http.go
View file

@ -381,7 +381,6 @@ func serviceRPC(h serviceHandler, service string) {
cmd.Stderr = &stderr cmd.Stderr = &stderr
if err := cmd.Run(); err != nil { if err := cmd.Run(); err != nil {
log.GitLogger.Error(2, "fail to serve RPC(%s): %v - %v", service, err, stderr) log.GitLogger.Error(2, "fail to serve RPC(%s): %v - %v", service, err, stderr)
h.w.WriteHeader(http.StatusInternalServerError)
return return
} }
} }