TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Remove redudant issue LoadAttributes() calls (#2614)

Browse source
This commit is contained in:
Morlinest 2017-09-27 14:41:52 +02:00 • committed by Andrey Nering
parent 339d7de409
commit cc84ca40d7
2 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
models/issue.go
View file

@ -984,12 +984,7 @@ func GetIssueByRef(ref string) (*Issue, error) {
return nil, err return nil, err
} }
issue, err := GetIssueByIndex(repo.ID, index) return GetIssueByIndex(repo.ID, index)
if err != nil {
return nil, err
}
return issue, issue.LoadAttributes()
} }
// GetRawIssueByIndex returns raw issue without loading attributes by index in a repository. // GetRawIssueByIndex returns raw issue without loading attributes by index in a repository.

6
routers/api/v1/repo/issue.go
View file

@ -39,12 +39,6 @@ func ListIssues(ctx *context.APIContext) {
return return
} }
err = models.IssueList(issues).LoadAttributes()
if err != nil {
ctx.Error(500, "LoadAttributes", err)
return
}
apiIssues := make([]*api.Issue, len(issues)) apiIssues := make([]*api.Issue, len(issues))
for i := range issues { for i := range issues {
apiIssues[i] = issues[i].APIFormat() apiIssues[i] = issues[i].APIFormat()