TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Remove jQuery from the citation modal (except fomantic) (#30008)

Browse source 
- Switched to plain JavaScript
- Tested the citation modal functionality and it works as before

# Demo using JavaScript without jQuery

![demo](https://github.com/go-gitea/gitea/assets/20454870/65bba1eb-dd4c-477f-8a2d-08e65f1e9f42)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit dade40407e333fbc6811bdd738c3d191b5dc0ef1)
This commit is contained in:
Yarden Shoham 2024-03-23 01:17:28 +02:00 committed by Earl Warren
parent c3e9b8b6f9
commit bc31bf2d09
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 21 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
web_src/js/features/citation.js
View file

@ -1,8 +1,9 @@
import $ from 'jquery'; import $ from 'jquery';
import {getCurrentLocale} from '../utils.js';
const {pageData} = window.config; const {pageData} = window.config;
async function initInputCitationValue($citationCopyApa, $citationCopyBibtex) { async function initInputCitationValue(citationCopyApa, citationCopyBibtex) {
const [{Cite, plugins}] = await Promise.all([ const [{Cite, plugins}] = await Promise.all([
import(/* webpackChunkName: "citation-js-core" */'@citation-js/core'), import(/* webpackChunkName: "citation-js-core" */'@citation-js/core'),
import(/* webpackChunkName: "citation-js-formats" */'@citation-js/plugin-software-formats'), import(/* webpackChunkName: "citation-js-formats" */'@citation-js/plugin-software-formats'),
@ -14,11 +15,11 @@ async function initInputCitationValue($citationCopyApa, $citationCopyBibtex) {
config.constants.fieldTypes.doi = ['field', 'literal']; config.constants.fieldTypes.doi = ['field', 'literal'];
config.constants.fieldTypes.version = ['field', 'literal']; config.constants.fieldTypes.version = ['field', 'literal'];
const citationFormatter = new Cite(citationFileContent); const citationFormatter = new Cite(citationFileContent);
const lang = document.documentElement.lang || 'en-US'; const lang = getCurrentLocale() || 'en-US';
const apaOutput = citationFormatter.format('bibliography', {template: 'apa', lang}); const apaOutput = citationFormatter.format('bibliography', {template: 'apa', lang});
const bibtexOutput = citationFormatter.format('bibtex', {lang}); const bibtexOutput = citationFormatter.format('bibtex', {lang});
$citationCopyBibtex.attr('data-text', bibtexOutput); citationCopyBibtex.setAttribute('data-text', bibtexOutput);
$citationCopyApa.attr('data-text', apaOutput); citationCopyApa.setAttribute('data-text', apaOutput);
} }
export async function initCitationFileCopyContent() { export async function initCitationFileCopyContent() {
@ -26,44 +27,45 @@ export async function initCitationFileCopyContent() {
if (!pageData.citationFileContent) return; if (!pageData.citationFileContent) return;
const $citationCopyApa = $('#citation-copy-apa'); const citationCopyApa = document.getElementById('citation-copy-apa');
const $citationCopyBibtex = $('#citation-copy-bibtex'); const citationCopyBibtex = document.getElementById('citation-copy-bibtex');
const $inputContent = $('#citation-copy-content'); const inputContent = document.getElementById('citation-copy-content');
if ((!citationCopyApa && !citationCopyBibtex) || !inputContent) return;
if ((!$citationCopyApa.length && !$citationCopyBibtex.length) || !$inputContent.length) return;
const updateUi = () => { const updateUi = () => {
const isBibtex = (localStorage.getItem('citation-copy-format') || defaultCitationFormat) === 'bibtex'; const isBibtex = (localStorage.getItem('citation-copy-format') || defaultCitationFormat) === 'bibtex';
const copyContent = (isBibtex ? $citationCopyBibtex : $citationCopyApa).attr('data-text'); const copyContent = (isBibtex ? citationCopyBibtex : citationCopyApa).getAttribute('data-text');
inputContent.value = copyContent;
$inputContent.val(copyContent); citationCopyBibtex.classList.toggle('primary', isBibtex);
$citationCopyBibtex.toggleClass('primary', isBibtex); citationCopyApa.classList.toggle('primary', !isBibtex);
$citationCopyApa.toggleClass('primary', !isBibtex);
}; };
$('#cite-repo-button').on('click', async (e) => { document.getElementById('cite-repo-button')?.addEventListener('click', async (e) => {
const dropdownBtn = e.target.closest('.ui.dropdown.button'); const dropdownBtn = e.target.closest('.ui.dropdown.button');
dropdownBtn.classList.add('is-loading'); dropdownBtn.classList.add('is-loading');
try { try {
try { try {
await initInputCitationValue($citationCopyApa, $citationCopyBibtex); await initInputCitationValue(citationCopyApa, citationCopyBibtex);
} catch (e) { } catch (e) {
console.error(`initCitationFileCopyContent error: ${e}`, e); console.error(`initCitationFileCopyContent error: ${e}`, e);
return; return;
} }
updateUi(); updateUi();
$citationCopyApa.on('click', () => { citationCopyApa.addEventListener('click', () => {
localStorage.setItem('citation-copy-format', 'apa'); localStorage.setItem('citation-copy-format', 'apa');
updateUi(); updateUi();
}); });
$citationCopyBibtex.on('click', () => {
citationCopyBibtex.addEventListener('click', () => {
localStorage.setItem('citation-copy-format', 'bibtex'); localStorage.setItem('citation-copy-format', 'bibtex');
updateUi(); updateUi();
}); });
$inputContent.on('click', () => { inputContent.addEventListener('click', () => {
$inputContent.trigger('select'); inputContent.select();
}); });
} finally { } finally {
dropdownBtn.classList.remove('is-loading'); dropdownBtn.classList.remove('is-loading');