unified name: IsViewBranch, IsViewCommit and IsViewTag

conf/app.ini

@@ -265,8 +265,8 @@ ADDR =
 ; For "smtp" mode only
 [log.smtp]
 LEVEL =
-; Name displayed in mail title, default is "Diagnostic message from serve"
-SUBJECT = Diagnostic message from serve
+; Name displayed in mail title, default is "Diagnostic message from server"
+SUBJECT = Diagnostic message from server
 ; Mail server
 HOST =
 ; Mailer user name and password

gogs.go

@@ -17,7 +17,7 @@ import (
 	"github.com/gogits/gogs/modules/setting"
 )
 
-const APP_VER = "0.7.35.1208 Beta"
+const APP_VER = "0.7.35.1209 Beta"
 
 func init() {
 	runtime.GOMAXPROCS(runtime.NumCPU())

modules/middleware/context.go

@@ -29,9 +29,9 @@ import (
 type RepoContext struct {
 	AccessMode   models.AccessMode
 	IsWatching   bool
-	IsBranch     bool
-	IsTag        bool
-	IsCommit     bool
+	IsViewBranch bool
+	IsViewTag    bool
+	IsViewCommit bool
 	Repository   *models.Repository
 	Owner        *models.User
 	Commit       *git.Commit

modules/middleware/repo.go

@@ -263,7 +263,7 @@ func RepoRef() macaron.Handler {
 				return
 			}
 			ctx.Repo.CommitID = ctx.Repo.Commit.ID.String()
-			ctx.Repo.IsBranch = true
+			ctx.Repo.IsViewBranch = true
 
 		} else {
 			hasMatched := false
@@ -286,7 +286,7 @@ func RepoRef() macaron.Handler {
 			}
 
 			if ctx.Repo.GitRepo.IsBranchExist(refName) {
-				ctx.Repo.IsBranch = true
+				ctx.Repo.IsViewBranch = true
 
 				ctx.Repo.Commit, err = ctx.Repo.GitRepo.GetCommitOfBranch(refName)
 				if err != nil {
@@ -296,7 +296,7 @@ func RepoRef() macaron.Handler {
 				ctx.Repo.CommitID = ctx.Repo.Commit.ID.String()
 
 			} else if ctx.Repo.GitRepo.IsTagExist(refName) {
-				ctx.Repo.IsTag = true
+				ctx.Repo.IsViewTag = true
 				ctx.Repo.Commit, err = ctx.Repo.GitRepo.GetCommitOfTag(refName)
 				if err != nil {
 					ctx.Handle(500, "GetCommitOfTag", err)
@@ -304,7 +304,7 @@ func RepoRef() macaron.Handler {
 				}
 				ctx.Repo.CommitID = ctx.Repo.Commit.ID.String()
 			} else if len(refName) == 40 {
-				ctx.Repo.IsCommit = true
+				ctx.Repo.IsViewCommit = true
 				ctx.Repo.CommitID = refName
 
 				ctx.Repo.Commit, err = ctx.Repo.GitRepo.GetCommit(refName)
@@ -321,9 +321,9 @@ func RepoRef() macaron.Handler {
 		ctx.Repo.BranchName = refName
 		ctx.Data["BranchName"] = ctx.Repo.BranchName
 		ctx.Data["CommitID"] = ctx.Repo.CommitID
-		ctx.Data["IsBranch"] = ctx.Repo.IsBranch
-		ctx.Data["IsTag"] = ctx.Repo.IsTag
-		ctx.Data["IsCommit"] = ctx.Repo.IsCommit
+		ctx.Data["IsViewBranch"] = ctx.Repo.IsViewBranch
+		ctx.Data["IsViewTag"] = ctx.Repo.IsViewTag
+		ctx.Data["IsViewCommit"] = ctx.Repo.IsViewCommit
 
 		ctx.Repo.CommitsCount, err = ctx.Repo.Commit.CommitsCount()
 		if err != nil {

routers/repo/view.go

@@ -53,9 +53,6 @@ func Home(ctx *middleware.Context) {
 		treeLink += "/" + treename
 	}
 
-	isViewBranch := ctx.Repo.IsBranch
-	ctx.Data["IsViewBranch"] = isViewBranch
-
 	treePath := treename
 	if len(treePath) != 0 {
 		treePath = treePath + "/"

templates/.VERSION

@@ -1 +1 @@
-0.7.35.1208 Beta
+0.7.35.1209 Beta

templates/repo/home.tmpl

@@ -39,14 +39,14 @@
 										</span>
 									</a>
 									<a class="reference column" href="#" data-target="#tag-list">
-										<span class="text {{if .IsTag}}black{{end}}">
+										<span class="text {{if .IsViewTag}}black{{end}}">
 											<i class="reference tags icon"></i> {{.i18n.Tr "repo.tags"}}
 										</span>
 									</a>
 								</div>
 							</div>
 						</div>
-						<div id="branch-list" class="scrolling menu" {{if .IsTag}}style="display: none"{{end}}>
+						<div id="branch-list" class="scrolling menu" {{if .IsViewTag}}style="display: none"{{end}}>
 							{{range .Branches}}
 								<div class="item {{if eq $.BranchName .}}selected{{end}}" data-url="{{$.RepoLink}}/src/{{EscapePound .}}">{{.}}</div>
 							{{end}}

templates/repo/view_file.tmpl

@@ -14,7 +14,7 @@
 		{{if not .ReadmeInList}}
 			<div class="ui right">
 				<div class="ui small grey basic buttons">
-					{{if not .IsCommit}}
+					{{if not .IsViewCommit}}
 						<a class="ui button" href="{{.RepoLink}}/src/{{.CommitID}}/{{EscapePound .TreeName}}">{{.i18n.Tr "repo.file_permalink"}}</a>
 					{{end}}
 					<a class="ui button" href="{{.RepoLink}}/commits/{{EscapePound .BranchName}}/{{EscapePound .TreeName}}">{{.i18n.Tr "repo.file_history"}}</a>

templates/repo/wiki/view.tmpl

@@ -18,7 +18,7 @@
 								<i class="filter icon"></i>
 								<input name="search" placeholder="{{.i18n.Tr "repo.wiki.filter_page"}}...">
 							</div>
-							<div class="scrolling menu" {{if .IsTag}}style="display: none"{{end}}>
+							<div class="scrolling menu">
 								{{range .Pages}}
 									<div class="item {{if eq $.Title .Name}}selected{{end}}" data-url="{{$.RepoLink}}/wiki/{{.URL}}">{{.Name}}</div>
 								{{end}}