From 9c9333868c3e3d1adfdc7bd3c12321845d28489a Mon Sep 17 00:00:00 2001 From: erik Date: Tue, 28 May 2024 12:38:27 +0200 Subject: [PATCH] Add todo We currently validate RepositoryID uris to be a valid api address from our own server. --- modules/forgefed/actor.go | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/forgefed/actor.go b/modules/forgefed/actor.go index d3cae20dec..ae1e96e37b 100644 --- a/modules/forgefed/actor.go +++ b/modules/forgefed/actor.go @@ -126,6 +126,7 @@ type RepositoryID struct { // Factory function for RepositoryID. Created struct is asserted to be valid. func NewRepositoryID(uri, source string) (RepositoryID, error) { + // ToDo: Here we check if the uri is coming from OUR machine. This fails for any urls pointing to other machines. if !validation.IsAPIURL(uri) { return RepositoryID{}, fmt.Errorf("uri %s is not a valid repo url on this host %s", uri, setting.AppURL+"api") }