TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Gitlab Migrator: dont ignore reactions of last request (#16903)

Browse source 
Fix bug related to early breaking when migrating reactions.
This commit is contained in:
6543 2021-09-01 12:20:19 +02:00 committed by GitHub
parent 57b0887ab2
commit 7062614dee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
modules/migrations/gitlab.go
View file

@ -421,12 +421,15 @@ func (g *GitlabDownloader) GetIssues(page, perPage int) ([]*base.Issue, bool, er
if err != nil { if err != nil {
return nil, false, fmt.Errorf("error while listing issue awards: %v", err) return nil, false, fmt.Errorf("error while listing issue awards: %v", err)
} }
if len(awards) < perPage {
break
}
for i := range awards { for i := range awards {
reactions = append(reactions, g.awardToReaction(awards[i])) reactions = append(reactions, g.awardToReaction(awards[i]))
} }
if len(awards) < perPage {
break
}
awardPage++ awardPage++
} }
@ -584,12 +587,15 @@ func (g *GitlabDownloader) GetPullRequests(page, perPage int) ([]*base.PullReque
if err != nil { if err != nil {
return nil, false, fmt.Errorf("error while listing merge requests awards: %v", err) return nil, false, fmt.Errorf("error while listing merge requests awards: %v", err)
} }
if len(awards) < perPage {
break
}
for i := range awards { for i := range awards {
reactions = append(reactions, g.awardToReaction(awards[i])) reactions = append(reactions, g.awardToReaction(awards[i]))
} }
if len(awards) < perPage {
break
}
awardPage++ awardPage++
} }