TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

minor refactorings

Browse source
This commit is contained in:
Michael Jerger 2023-12-13 16:06:53 +01:00
parent 44e10ed65a
commit 6de8fba14d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
routers/api/v1/activitypub/repository.go
View file

@ -95,7 +95,7 @@ func SearchUsersByLoginName(loginName string) ([]*user_model.User, error) {
} }
// TODO: Move most of this fkt to http client // TODO: Move most of this fkt to http client
func getBody(remoteStargazer, starReceiver string, ctx *context.APIContext) ([]byte, error) { // ToDo: We could split this: move body reading to unmarshall func getBody(remoteStargazer, signerId string, ctx *context.APIContext) ([]byte, error) { // ToDo: We could split this: move body reading to unmarshall
// TODO: The star receiver signs the http get request will maybe not work. // TODO: The star receiver signs the http get request will maybe not work.
// The remote repo has probably diferent keys as the local one. // The remote repo has probably diferent keys as the local one.
@ -103,12 +103,12 @@ func getBody(remoteStargazer, starReceiver string, ctx *context.APIContext) ([]b
// Why should we use a signed request here at all? // Why should we use a signed request here at all?
// > To provide an extra layer of security against in flight tampering: https://github.com/go-fed/httpsig/blob/55836744818e/httpsig.go#L116 // > To provide an extra layer of security against in flight tampering: https://github.com/go-fed/httpsig/blob/55836744818e/httpsig.go#L116
client, err := api.NewClient(ctx, actionsUser, starReceiver) // ToDo: Do we get a publicKeyId of owner or repo? client, err := api.NewClient(ctx, actionsUser, signerId) // ToDo: Do we get a publicKeyId of owner or repo?
if err != nil { if err != nil {
return []byte{0}, err return []byte{0}, err
} }
// get_person_by_rest // get_person_by_rest
response, err := client.Get([]byte{0}, remoteStargazer) response, err := client.Get(remoteStargazer)
if err != nil { if err != nil {
return []byte{0}, err return []byte{0}, err
} }