[GITEA] Check for Commit in opengraph
- It's possible that `PageIsDiff` is set but not `Commit` resulting in a NPE in the template. This can happen when the requested commit doesn't exist. - Regression ofc802c46a9b
&5743d7cb5b
- Added 'hacky' integration test. (cherry picked from commit8db2d5e4a7
) (cherry picked from commit8c737a802b
) (cherry picked from commit6b7c7d18dc
) (cherry picked from commita2be4fab27
) (cherry picked from commita1125268ac
)
This commit is contained in:
parent
f90b802634
commit
159dc74ceb
1 changed files with 6 additions and 1 deletions
|
@ -683,7 +683,12 @@ func TestCommitView(t *testing.T) {
|
||||||
defer tests.PrintCurrentTest(t)()
|
defer tests.PrintCurrentTest(t)()
|
||||||
|
|
||||||
req := NewRequest(t, "GET", "/user2/repo1/commit/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
|
req := NewRequest(t, "GET", "/user2/repo1/commit/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
|
||||||
MakeRequest(t, req, http.StatusNotFound)
|
req.SetHeader("Accept", "text/html")
|
||||||
|
resp := MakeRequest(t, req, http.StatusNotFound)
|
||||||
|
|
||||||
|
// Really ensure that 404 is being sent back.
|
||||||
|
doc := NewHTMLParser(t, resp.Body)
|
||||||
|
doc.AssertElement(t, `[aria-label="Page Not Found"]`, true)
|
||||||
})
|
})
|
||||||
|
|
||||||
t.Run("Too short commit ID", func(t *testing.T) {
|
t.Run("Too short commit ID", func(t *testing.T) {
|
||||||
|
|
Loading…
Reference in a new issue