TudbuT/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

use gitRepo.GetCommit directly

Browse source 
and give it a commitID instead of a branchName (a bit more correct and faster)
This commit is contained in:
oliverpool 2024-03-18 12:26:38 +01:00
parent 286d09203f
commit 0a53eb838d
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
routers/private/hook_post_receive.go
View file

@ -142,9 +142,7 @@ func HookPostReceive(ctx *gitea_context.PrivateContext) {
commitIDs = append(commitIDs, update.NewCommitID) commitIDs = append(commitIDs, update.NewCommitID)
} }
if err := repo_service.SyncBranchesToDB(ctx, repo.ID, opts.UserID, branchNames, commitIDs, func(commitID string) (*git.Commit, error) { if err := repo_service.SyncBranchesToDB(ctx, repo.ID, opts.UserID, branchNames, commitIDs, gitRepo.GetCommit); err != nil {
return gitRepo.GetCommit(commitID)
}); err != nil {
ctx.JSON(http.StatusInternalServerError, private.HookPostReceiveResult{ ctx.JSON(http.StatusInternalServerError, private.HookPostReceiveResult{
Err: fmt.Sprintf("Failed to sync branch to DB in repository: %s/%s Error: %v", ownerName, repoName, err), Err: fmt.Sprintf("Failed to sync branch to DB in repository: %s/%s Error: %v", ownerName, repoName, err),
}) })

2
services/repository/branch.go
View file

@ -283,7 +283,7 @@ func SyncBranchesToDB(ctx context.Context, repoID, pusherID int64, branchNames,
continue continue
} }
commit, err := getCommit(branchName) commit, err := getCommit(commitID)
if err != nil { if err != nil {
return fmt.Errorf("get commit of %s failed: %v", branchName, err) return fmt.Errorf("get commit of %s failed: %v", branchName, err)
} }