refactor: avoid some allocations when redacting

This commit is contained in:
Timo 2020-08-12 15:33:45 +02:00
parent 04eee089e0
commit 940f533d61
No known key found for this signature in database
GPG key ID: 24DA7517711A2BA4

View file

@ -37,11 +37,12 @@ pub struct PduEvent {
impl PduEvent {
pub fn redact(&mut self) -> Result<()> {
self.unsigned.clear();
let allowed = match self.kind {
EventType::RoomMember => vec!["membership"],
EventType::RoomCreate => vec!["creator"],
EventType::RoomJoinRules => vec!["join_rule"],
EventType::RoomPowerLevels => vec![
let allowed: &[&str] = match self.kind {
EventType::RoomMember => &["membership"],
EventType::RoomCreate => &["creator"],
EventType::RoomJoinRules => &["join_rule"],
EventType::RoomPowerLevels => &[
"ban",
"events",
"events_default",
@ -51,8 +52,8 @@ impl PduEvent {
"users",
"users_default",
],
EventType::RoomHistoryVisibility => vec!["history_visibility"],
_ => vec![],
EventType::RoomHistoryVisibility => &["history_visibility"],
_ => &[],
};
let old_content = self
@ -63,8 +64,8 @@ impl PduEvent {
let mut new_content = serde_json::Map::new();
for key in allowed {
if let Some(value) = old_content.remove(key) {
new_content.insert(key.to_owned(), value);
if let Some(value) = old_content.remove(*key) {
new_content.insert((*key).to_owned(), value);
}
}