From 931e1cad06cfcb7b5a23992180f282dc7a303be7 Mon Sep 17 00:00:00 2001 From: strawberry Date: Fri, 22 Mar 2024 21:50:19 -0400 Subject: [PATCH] ci: make docker username and GHCR variables Signed-off-by: strawberry --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6296fc78..872faaad 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,6 +19,7 @@ env: # Custom nix binary cache if fork is being used ATTIC_ENDPOINT: ${{ vars.ATTIC_ENDPOINT }} ATTIC_PUBLIC_KEY: ${{ vars.ATTIC_PUBLIC_KEY }} + DOCKER_USERNAME: ${{ vars.DOCKER_USERNAME }} permissions: packages: write @@ -184,7 +185,8 @@ jobs: if: github.event_name != 'pull_request' uses: docker/login-action@v3 with: - username: girlbossceo + # username is not really a secret + username: ${{ vars.DOCKER_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} - name: Login to GitHub Container Registry @@ -194,7 +196,7 @@ jobs: REGISTRY: ghcr.io with: registry: ${{ env.REGISTRY }} - username: girlbossceo + username: ${{ github.repository_owner }} password: ${{ secrets.GITHUB_TOKEN }}