From 68b96026ec0ce76543bcc237173554564605b57e Mon Sep 17 00:00:00 2001 From: Benjamin Lee Date: Fri, 24 May 2024 17:02:20 -0700 Subject: [PATCH] unmark dynamically-linked jemalloc builds as broken It turns out that this was actually fixed by bec507d7390dda9ca2e624ef846521a20e2252c7 and 857ac42aacf430f14a9b7108591cea91185af8b3, but we didn't identify it at the time. Notably, the `dynamic` devshell is still broken. --- nix/pkgs/main/default.nix | 7 ------- 1 file changed, 7 deletions(-) diff --git a/nix/pkgs/main/default.nix b/nix/pkgs/main/default.nix index 2d2e4ab8..5d31fe15 100644 --- a/nix/pkgs/main/default.nix +++ b/nix/pkgs/main/default.nix @@ -190,11 +190,4 @@ craneLib.buildPackage ( commonAttrs // { }; meta.mainProgram = commonAttrs.pname; - # Dynamically-linked jemalloc is broken on linux due to link-order problems, - # where the symbols are being resolved to libc malloc/free before jemalloc is - # loaded. This problem does not occur on darwin for unknown reasons. - meta.broken = - stdenv.isLinux && - !stdenv.hostPlatform.isStatic && - (featureEnabled "jemalloc"); })