From 54f4d39e3ed92106ec3a902de22d2366cfd8e8be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timo=20K=C3=B6sters?= <timo@koesters.xyz>
Date: Tue, 21 Dec 2021 16:02:12 +0100
Subject: [PATCH] improvement: don't fetch event multiple times

---
 src/database/abstraction/rocksdb.rs |  4 +++-
 src/server_server.rs                | 17 +++++++++++++----
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/src/database/abstraction/rocksdb.rs b/src/database/abstraction/rocksdb.rs
index b2142dfe..397047bd 100644
--- a/src/database/abstraction/rocksdb.rs
+++ b/src/database/abstraction/rocksdb.rs
@@ -27,7 +27,9 @@ impl DatabaseEngine for Engine {
         db_opts.set_num_levels(8);
         db_opts.set_write_buffer_size(2 << 27);
 
-        let rocksdb_cache = rocksdb::Cache::new_lru_cache((config.db_cache_capacity_mb * 1024.0 * 1024.0) as usize).unwrap();
+        let rocksdb_cache =
+            rocksdb::Cache::new_lru_cache((config.db_cache_capacity_mb * 1024.0 * 1024.0) as usize)
+                .unwrap();
 
         let mut block_based_options = rocksdb::BlockBasedOptions::default();
         block_based_options.set_block_size(2 << 19);
diff --git a/src/server_server.rs b/src/server_server.rs
index 57f55867..6e8ebf38 100644
--- a/src/server_server.rs
+++ b/src/server_server.rs
@@ -1867,7 +1867,12 @@ pub(crate) fn fetch_and_handle_outliers<'a>(
             // handle_outlier_pdu.
             let mut todo_auth_events = vec![Arc::clone(id)];
             let mut events_in_reverse_order = Vec::new();
+            let mut events_all = HashSet::new();
             while let Some(next_id) = todo_auth_events.pop() {
+                if events_all.contains(&next_id) {
+                    continue;
+                }
+
                 if let Ok(Some(_)) = db.rooms.get_pdu(&next_id) {
                     trace!("Found {} in db", id);
                     continue;
@@ -1899,10 +1904,13 @@ pub(crate) fn fetch_and_handle_outliers<'a>(
                                 next_id, calculated_event_id, &res.pdu);
                         }
 
-
-                        if let Some(auth_events) = value.get("auth_events").and_then(|c| c.as_array()) {
+                        if let Some(auth_events) =
+                            value.get("auth_events").and_then(|c| c.as_array())
+                        {
                             for auth_event in auth_events {
-                                if let Ok(auth_event) = serde_json::from_value(auth_event.clone().into()) {
+                                if let Ok(auth_event) =
+                                    serde_json::from_value(auth_event.clone().into())
+                                {
                                     let a: Arc<EventId> = auth_event;
                                     todo_auth_events.push(a);
                                 } else {
@@ -1913,7 +1921,8 @@ pub(crate) fn fetch_and_handle_outliers<'a>(
                             warn!("Auth event list invalid");
                         }
 
-                        events_in_reverse_order.push((next_id, value));
+                        events_in_reverse_order.push((next_id.clone(), value));
+                        events_all.insert(next_id);
                     }
                     Err(_) => {
                         warn!("Failed to fetch event: {}", next_id);