TudbuT/conduit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove comments, log channel errors

Browse source 
Signed-off-by: strawberry <strawberry@puppygock.gay>
This commit is contained in:
strawberry 2024-04-07 12:41:06 -04:00 • committed by June
parent 68321ec467
commit 3438b340a9
3 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/service/admin/mod.rs
View file

@ -183,12 +183,9 @@ impl Service {
}
drop(state_lock);
}
Err(_) => {
// TODO: Handle error, Im too unfamiliar with the codebase to know what to do here
// recv_async returns an error if all senders have been dropped. If the channel is empty, the returned future will yield to the async runtime.
Err(e) => {
// generally shouldn't happen
error!("Failed to receive admin room event from channel: {e}");
}
}
}

4
src/service/presence/mod.rs
View file

@ -181,8 +181,8 @@ impl Service {
presence_timers.push(presence_timer(user_id, timeout));
}
Err(e) => {
// TODO: Handle error better? I have no idea what to do here.
error!("Failed to receive presence timer: {}", e);
// generally shouldn't happen
error!("Failed to receive presence timer through channel: {e}");
}
}
}

1
src/service/sending/mod.rs
View file

@ -342,7 +342,6 @@ impl Service {
},
event = receiver.recv_async() => {
// TODO: Error handling for this
if let Ok((outgoing_kind, event, key)) = event {
if let Ok(Some(events)) = self.select_events(
&outgoing_kind,