TudbuT/conduit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

syncv3: handle empty conn_id by mapping it to a predefined string

Browse source
This commit is contained in:
morguldir 2024-08-24 06:45:33 +02:00
parent 351062eb82
commit 13334a88ca
No known key found for this signature in database
GPG key ID: 5A6025D4F6E7A8A3
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/api/client/sync.rs
View file

@ -7,7 +7,9 @@ use std::{
use axum::extract::State;
use conduit::{
error, utils::math::{ruma_from_u64, ruma_from_usize, usize_from_ruma, usize_from_u64_truncated}, warn, Err, PduCount
error,
utils::math::{ruma_from_u64, ruma_from_usize, usize_from_ruma, usize_from_u64_truncated},
warn, Err, PduCount,
};
use ruma::{
api::client::{
@ -27,7 +29,10 @@ use ruma::{
presence::PresenceEvent,
room::member::{MembershipState, RoomMemberEventContent},
StateEventType, TimelineEventType,
}, room::RoomType, serde::Raw, uint, DeviceId, EventId, OwnedRoomId, OwnedUserId, RoomId, UInt, UserId
},
room::RoomType,
serde::Raw,
uint, DeviceId, EventId, OwnedRoomId, OwnedUserId, RoomId, UInt, UserId,
};
use tracing::{Instrument as _, Span};
@ -36,6 +41,8 @@ use crate::{
utils, Error, PduEvent, Result, Ruma, RumaResponse,
};
const SINGLE_CONNECTION_SYNC: &str = "single_connection_sync";
/// # `GET /_matrix/client/r0/sync`
///
/// Synchronize the client's state with the latest state on the server.
@ -1083,6 +1090,11 @@ pub(crate) async fn sync_events_v4_route(
let next_batch = services.globals.next_count()?;
let conn_id = body
.conn_id
.clone()
.unwrap_or_else(|| SINGLE_CONNECTION_SYNC.to_owned());
let globalsince = body
.pos
.as_ref()
@ -1090,11 +1102,9 @@ pub(crate) async fn sync_events_v4_route(
.unwrap_or(0);
if globalsince == 0 {
if let Some(conn_id) = &body.conn_id {
services
.users
.forget_sync_request_connection(sender_user.clone(), sender_device.clone(), conn_id.clone());
}
services
.users
.forget_sync_request_connection(sender_user.clone(), sender_device.clone(), conn_id.clone());
}
// Get sticky parameters from cache