jess-refactor #11

Closed
TudbuT wants to merge 7 commits from jess-refactor into main
Owner

making this a PR since it broke a bunch of things in minor and major ways and misunderstood the purpose of several classes.

making this a PR since it broke a bunch of things in minor and major ways and misunderstood the purpose of several classes.
TudbuT added 6 commits 2024-06-04 05:52:59 +02:00
TudbuT reviewed 2024-06-04 06:05:37 +02:00
TudbuT left a comment
Author
Owner

h

h
@ -0,0 +22,4 @@
*/
public class FeatureManager {
public static Feature[] features = new Feature[0];
Author
Owner

unlike the entire rest of this class, this field is static.

unlike the entire rest of this class, this field is static.
@ -0,0 +25,4 @@
public static Feature[] features = new Feature[0];
public final String Name = "BaseBand";
public final String RegistryFilename = "baseband.db";
public final int Port = 7258;
Author
Owner

as you can sre form there being a name and port, this actually manages all aspects of the client's setup, and not just features. indeed the BaseBand class is significantly more like a FeatureManager than Setup, because Setup is only a set of parameters.

as you can sre form there being a name and port, this actually manages all aspects of the client's setup, and not just features. indeed the BaseBand class is significantly more like a FeatureManager than Setup, because Setup is only a set of parameters.
@ -0,0 +89,4 @@
public void init() {
Author
Owner

you first put stuff into the constructor and then deleted it, so there is now no constructor. that means its no longer a singleton class and could be instantiated more than once

you first put stuff into the constructor and then deleted it, so there is now no constructor. that means its no longer a singleton class and could be instantiated more than once
@ -45,2 +45,2 @@
ChatUtil.history(message);
ChatUtil.send(applyWatermark((custom ? (customUnicodeToggle ? toUnicode(customWatermark) : customWatermark) : toUnicode("baseband")), message), false);
IngameLogger.history(message);
IngameLogger.send(applyWatermark((custom ? (customUnicodeToggle ? toUnicode(customWatermark) : customWatermark) : toUnicode("baseband")), message), false);
Author
Owner

ChatUtils being renamed causes a severe shift of meanings here, to where now these statements read incorrectly

ChatUtils being renamed causes a severe shift of meanings here, to where now these statements read incorrectly
@ -0,0 +6,4 @@
import java.lang.reflect.Method;
import java.security.SecureRandom;
public class ImplUtil {
Author
Owner

I get that GlobalUtil is a bad name but I don't see the appeal of ImplUtil either

I get that GlobalUtil is a bad name but I don't see the appeal of ImplUtil either
TudbuT added 1 commit 2024-06-04 08:08:38 +02:00
Author
Owner

remade with fixes

remade with fixes
TudbuT closed this pull request 2024-06-04 09:41:34 +02:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: BaseBand/BaseBandRewrite#11
No description provided.