jess-refactor #11
No reviewers
Labels
No labels
Bug
Core
Improvement/Polish
New feature
On hold
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: BaseBand/BaseBandRewrite#11
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "jess-refactor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
making this a PR since it broke a bunch of things in minor and major ways and misunderstood the purpose of several classes.
h
@ -0,0 +22,4 @@
*/
public class FeatureManager {
public static Feature[] features = new Feature[0];
unlike the entire rest of this class, this field is static.
@ -0,0 +25,4 @@
public static Feature[] features = new Feature[0];
public final String Name = "BaseBand";
public final String RegistryFilename = "baseband.db";
public final int Port = 7258;
as you can sre form there being a name and port, this actually manages all aspects of the client's setup, and not just features. indeed the BaseBand class is significantly more like a FeatureManager than Setup, because Setup is only a set of parameters.
@ -0,0 +89,4 @@
public void init() {
you first put stuff into the constructor and then deleted it, so there is now no constructor. that means its no longer a singleton class and could be instantiated more than once
@ -45,2 +45,2 @@
ChatUtil.history(message);
ChatUtil.send(applyWatermark((custom ? (customUnicodeToggle ? toUnicode(customWatermark) : customWatermark) : toUnicode("baseband")), message), false);
IngameLogger.history(message);
IngameLogger.send(applyWatermark((custom ? (customUnicodeToggle ? toUnicode(customWatermark) : customWatermark) : toUnicode("baseband")), message), false);
ChatUtils being renamed causes a severe shift of meanings here, to where now these statements read incorrectly
@ -0,0 +6,4 @@
import java.lang.reflect.Method;
import java.security.SecureRandom;
public class ImplUtil {
I get that GlobalUtil is a bad name but I don't see the appeal of ImplUtil either
remade with fixes
Pull request closed